Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][runtime][patch]: Fix for RM#2679
Дата
Msg-id CA+OCxozoRsQqt9Nq6o9e084kB+89_jUJN9LY_jjCdwpDhqC0+w@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][runtime][patch]: Fix for RM#2679  (Neel Patel <neel.patel@enterprisedb.com>)
Ответы Re: [pgAdmin4][runtime][patch]: Fix for RM#2679
Список pgadmin-hackers
Дерево обсуждения
Hi

On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch to fix RM#2679.

Issue:-
Getting started links does not open second time from "Dashboard" panel if User close runtime tab and open any URL again.

Analysis:-
As in runtime Qt application, when user defined "target=_new" then "createWindow" signal is called but when user close that new windows and again click on link then "createWindow" signal is not getting called so from user point view nothing will happen.

Solution:-
To make it work in both runtime and web application, changed "target" attribute to "_blank" so that "createWindow" signal will be called every time when user click on any link.

I think this is a partial workaround for the problem. We link to external sites such as postgresql.org - what happens if that tries to open something with target="_new"? It should be expected to work as well. I think we need to fix the underlying problem, not try to work around it. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Ensure we can download large files and keep theuser
Следующее
От: pgAdmin 4 Jenkins
Дата:
Сообщение: Build failed in Jenkins: pgadmin4-master-python26 #513