Thanks - patch applied (with a doc update).
On Tue, Jan 29, 2019 at 6:41 AM Diego Augusto Molina
<diegoaugustomolina@gmail.com> wrote:
>
> Hi, Dave
>
> On 1/22/19, Dave Page <dpage@pgadmin.org> wrote:
> > Hi
> >
> > On Wed, Jan 16, 2019 at 12:41 PM Diego Augusto Molina
> > <diegoaugustomolina@gmail.com> wrote:
> >>
> >> Here's the patch, sorry for the bad manners.
> >
> > That effectively reverts the fix committed to resolve this doesn't it?
> > https://redmine.postgresql.org/issues/3392
>
> Yeah, it really does.
>
> >
> > Maybe the way to go is to expose the bind address (or some options to
> > control it) in variables that can be set at launch time, leaving the
> > default as-is.
> >
> > Thoughts?
>
> Sounds like the way to go. There goes the new humble patch for the
> "/entrypoint.sh", which runs just fine. The new environment variable
> is named PGADMIN_LISTEN_ADDRESS and defaults to "[::]". Tested with
> the following Dockerfile:
>
> $Dockerfile$
> FROM dpage/pgadmin4:latest
>
> RUN sed -i 's/\[::\]/${PGADMIN_BIND_ADDRESS:-[::]}/' /entrypoint.sh
>
> # This is just candy but could be added for ease of use in debugging:
> SHELL ["/bin/sh"]
>
> $Dockerfile$
>
>
>
> Thanks a lot!
>
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company