Re: [pgadmin-hackers][patch] Update chrome driver to support chromeversion 58 in tests

Hi Hackers,

We recreated the patch and should work now.

The problem looks like an issue with pip. I just opened an issue in their github.

Thanks

Joao & Oliver

On Fri, Apr 21, 2017 at 5:20 AM, Dave Page <dpage@pgadmin.org> wrote:

Hi,

Unfortunately I've had to revert this as the Jenkins CI builds started failing on all branches. It appears that the --install-option for chromerdriver_installer is also passed to pyperclip, which then barfs on it:

/var/lib/jenkins/workspace/pgadmin4-master-python27/pgadmin-venv/lib/python2.7/site-packages/pip/req/req_file.py:150: UserWarning: Disabling all use of wheels due to the use of --build-options / --global-options / --install-options. cmdoptions.check_install_build_global(options, opts)
Collecting chromedriver_installer==0.0.6 (from -r web/regression/requirements.txt (line 1)) Using cached chromedriver_installer-0.0.6.tar.gz
Collecting pyperclip~=1.5.27 (from -r web/regression/requirements.txt (line 2)) Using cached pyperclip-1.5.27.zip
Collecting selenium==3.3.1 (from -r web/regression/requirements.txt (line 3)) Using cached selenium-3.3.1.tar.gz
Collecting testscenarios==0.5.0 (from -r web/regression/requirements.txt (line 4)) Using cached testscenarios-0.5.0.tar.gz
Collecting testtools==2.0.0 (from -r web/regression/requirements.txt (line 5)) Using cached testtools-2.0.0.tar.gz
Requirement already satisfied: traceback2==1.4.0 in ./pgadmin-venv/lib/python2.7/site-packages (from -r web/regression/requirements.txt (line 6))
Requirement already satisfied: unittest2==1.1.0 in ./pgadmin-venv/lib/python2.7/site-packages (from -r web/regression/requirements.txt (line 7))
Requirement already satisfied: pbr>=0.11 in ./pgadmin-venv/lib/python2.7/site-packages (from testscenarios==0.5.0->-r web/regression/requirements.txt (line 4))
Requirement already satisfied: extras in ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r web/regression/requirements.txt (line 5))
Requirement already satisfied: fixtures>=1.3.0 in ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r web/regression/requirements.txt (line 5))
Requirement already satisfied: pyrsistent in ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r web/regression/requirements.txt (line 5))
Requirement already satisfied: python-mimeparse in ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r web/regression/requirements.txt (line 5))
Requirement already satisfied: linecache2 in ./pgadmin-venv/lib/python2.7/site-packages (from traceback2==1.4.0->-r web/regression/requirements.txt (line 6))
Requirement already satisfied: argparse in ./pgadmin-venv/lib/python2.7/site-packages (from unittest2==1.1.0->-r web/regression/requirements.txt (line 7))
Requirement already satisfied: six>=1.4 in ./pgadmin-venv/lib/python2.7/site-packages (from unittest2==1.1.0->-r web/regression/requirements.txt (line 7))
Skipping bdist_wheel for chromedriver-installer, due to binaries being disabled for it.
Skipping bdist_wheel for pyperclip, due to binaries being disabled for it.
Skipping bdist_wheel for selenium, due to binaries being disabled for it.
Skipping bdist_wheel for testscenarios, due to binaries being disabled for it.
Skipping bdist_wheel for testtools, due to binaries being disabled for it.
Installing collected packages: chromedriver-installer, pyperclip, selenium, testtools, testscenarios Running setup.py install for chromedriver-installer: started   Running setup.py install for chromedriver-installer: finished with status 'done' Running setup.py install for pyperclip: started   Running setup.py install for pyperclip: finished with status 'error'   Complete output from command /var/lib/jenkins/workspace/pgadmin4-master-python27/pgadmin-venv/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-YzPhsw/pyperclip/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-Sy2sJJ-record/install-record.txt --single-version-externally-managed --compile --install-headers /var/lib/jenkins/workspace/pgadmin4-master-python27/pgadmin-venv/include/site/python2.7/pyperclip --chromedriver-version=2.29:   usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]      or: -c --help [cmd1 cmd2 ...]      or: -c --help-commands      or: -c cmd --help      error: option --chromedriver-version not recognized

On Fri, Apr 21, 2017 at 9:54 AM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, patch applied.

On Thu, Apr 20, 2017 at 11:03 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hi Hackers,

With the update to version 58 of chrome the version of the chrome driver of Selenium need to be updated to version 2.29.

This patch does that change.

Note:

If you had previously installed the old driver you need to uninstall and install again it.

$ pip uninstall chromedriver_installer
$ pip install -r regression/requirements.txt

​

Thanks

Joao & Oliver

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company