Re: News review in dark mode
| От | Dave Page |
|---|---|
| Тема | Re: News review in dark mode |
| Дата | |
| Msg-id | CA+OCxoz1oTcN9sJ4nAUwuvqPwr4yskZEYDVeyaCBctf-5tnqZg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: News review in dark mode ("Jonathan S. Katz" <jkatz@postgresql.org>) |
| Список | pgsql-www |
On Thu, 27 Nov 2025 at 16:04, Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 11/26/25 9:50 AM, Álvaro Herrera wrote:
> On 2025-Nov-26, Dave Page wrote:
>
>> It's bugged me for ages that the news preview in dark mode has been broken
>> forever. Here's a patch to fix that, along with before/after screenshots.
>
> Oh, yes _please_, thank you very much.
+1 for the feature.
Code overall looks fine to me. I'd prefer if we could make the
"try/catch" block be more discerning about opting to ignore the
Cross-Origin error, but given the contents of the try block are benign,
I wouldn't block the patch on that.
Thanks - this has been pushed with a minor tweak to the catch block:
} catch (e) {
/* Only ignore SecurityError/cross-origin errors, rethrow others */
if (e.name !== 'SecurityError') {
throw e;
}
}
/* Only ignore SecurityError/cross-origin errors, rethrow others */
if (e.name !== 'SecurityError') {
throw e;
}
}
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
В списке pgsql-www по дате отправления: