Re: WIP: SQL Formatter

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: WIP: SQL Formatter
Дата
Msg-id CA+OCxoyLSyMB6HF7ty085gngD2=GYXQkUffY4zJtGaDL2oZrkw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: WIP: SQL Formatter  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Ответы Re: WIP: SQL Formatter  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Hi

Currently, all the CodeMirrors in pgAdmin use the settings from the Query tool -> Editor, even though they're not related.  I think you're right. We should move all CodeMirror settings out of the Query tool and move it to a new node - "SQL" may be. Editor and Auto-format would be sub nodes under SQL. With that, the editor settings will apply at all the places where CodeMirror editing is used(function body, query tool). What do you say ?

Turns out that's more work than I really have time for at the moment, because it means making the editors be able to handle automatic reloads of multiple preference sections. We can always think about moving the formatting preferences into their own section later.

In the meantime, this update to the patch does what was originally suggested and puts the options into a Query Tool -> SQL Formatting section.

Comments? Obviously docs will need updating too, once we're all happy with the basics.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Satish V
Дата:
Сообщение: [pgAdmin 4 - Housekeeping #5327][Code Coverage] Improve API test cases for Schemas and Catalog Objects
Следующее
От: Yogesh Mahajan
Дата:
Сообщение: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)