Re: [pgAdmin4][Patch]: Partition table fix

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][Patch]: Partition table fix
Дата
Msg-id CA+OCxoy6CsVgNq1hzGKfN-z6igWMdF_fnhmT612cqduc4e2N0g@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: Partition table fix  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: Partition table fix  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Hi

On Fri, Jul 20, 2018 at 10:42 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the issue : The right panels (properties, SQL etc...) give error while clicking on the partitions of a table.

This fails tests for me:

HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 304 of 741 SUCCESS (0 secs / 4.711 secs)

HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy getTreeNodeHierarchy is called with aciTreeNode object When tree has table when table has partition returns table with partition parameters FAILED

Expected object not to have properties

    partition: Object({ some key: 'expected value', _type: 'partition', some other key: 'some other value', priority: 0 })

    at UserContext.<anonymous> (regression/javascript/tree/webpack:/regression/javascript/tree/pgadmin_tree_node_spec.js:177:26)

HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 680 of 741 (1 FAILED) (0 secs / 6.981 secs)

HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy getTreeNodeHierarchy is called with aciTreeNode object When tree has table when table has partition returns table with partition parameters FAILED

Expected object not to have properties

    partition: Object({ some key: 'expected value', _type: 'partition', some other key: 'some other value', priority: 0 })

HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy getTreeNodeHierarchy is called with TreeNode object When tree has table when table has partition returns table with partition parameters FAILED

Expected object not to have properties

    partition: Object({ some key: 'expected value', _type: 'partition', some other key: 'some other value', priority: 0 })

    at UserContext.<anonymous> (regression/javascript/tree/webpack:/regression/javascript/tree/pgadmin_tree_node_spec.js:336:26)

HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 686 of 741 (2 FAILED) (0 secs / 6.999 secs)

HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy getTreeNodeHierarchy is called with TreeNode object When tree has table when table has partition returns table with partition parameters FAILED

Expected object not to have properties

    partition: Object({ some key: 'expected value', _type: 'partition', some other key: 'some other value', priority: 0 })

HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 741 of 741 (2 FAILED) (7.47 secs / 7.149 secs)

error Command failed with exit code 1.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

make: *** [check] Error 1  


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Remove comment that's not really needed any more.
Следующее
От: Khushboo Vashi
Дата:
Сообщение: Re: [pgAdmin4][Patch]: Partition table fix