Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool
Дата
Msg-id CA+OCxoy5rp9PK55m476-Fwia70x2KSnRY-Bah=tsdFxXNrg5wg@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi

On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to fix the issue where logic to extract the error using RegEX from error message was incorrect in Query tool(History tab).
RM#2700

Thanks - applied, but....

- Could you please add some JS tests to ensure parseErrorMessage continues to work as it should.

- I'm not happy with the fact that we still display:

can't execute an empty query ********** Error **********

Can we not make that look more like a real error message? At the very least something like:

Error: can't execute an empty query
 

Another minor issue which I observed on login page is that close button on alert is little misaligned(screenshot attached).


Also applied - thanks! 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Correct alignment of the X button on dismissablealer
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Fix tablespace move prompt message. Fixes #2708