Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

Dave, 

Any update on this? Should I commit the patch? 

On Wed, 4 Dec, 2019, 11:57 Akshay Joshi, <akshay.joshi@enterprisedb.com> wrote:

Hi Dave,

Should I commit this patch, are you happy with the new icons? 

On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Dave,

I've sent a patch for the new icon. It is not a play icon but thoughts on the sent patch ? Below is the icon:

On Tue, Dec 3, 2019 at 4:09 PM Dave Page <dpage@pgadmin.org> wrote:

I intentionally didn't change that one as I wasn't sure what icon would be better. I'm far from convinced that it should also be a play icon.

On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to change toolbar icon for opening query tool inline with execute button change.

Icon for table filter button on the toolbar is also changed as below:

On Tue, Dec 3, 2019 at 7:15 AM Dave Page <dpage@pgadmin.org> wrote:

Use a 'play' icon for the Execute Query button in the Query Tool for greater consistency with other applications. Fixes #4711

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff9320

Modified Files
--------------
docs/en_US/release_notes_4_16.rst                        | 1 +
web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)

--

Thanks and Regards,

Aditya Toshniwal

Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks and Regards,

Aditya Toshniwal

Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246