Re: Patch: Added select2cell editor for backgrid [pgAdmin4]

Thanks - committed with small changes.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA updated patch.

Regards,

Murtuza

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Apr 1, 2016 at 3:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

We have added Select2Cell Editor for backgrid, eariler as it was not present & causing issue in rendering in subnode control.

Looks good to me, but - have some feedback.

1. Can you please mention - why do we need 'openOnEnter: false' in select2 options?

2. There is a difference between UI, when rendered from the editor, and from the Select2Cell. (I can see padding, when the Cell is rendered, but - not when editor is rendered.)

Can you please fix this two?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers