Re: Patch to remove Python 2.7 support in the macOS Appbundle

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: Patch to remove Python 2.7 support in the macOS Appbundle
Дата
Msg-id CA+OCxoxsr+hDf4LhU_=F74QgrRw-_KLoZi_DRubMf0mVuj_aKw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Patch to remove Python 2.7 support in the macOS Appbundle  (Dave Page <dpage@pgadmin.org>)
Ответы Re: Patch to remove Python 2.7 support in the macOS Appbundle  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Akshay, are you happy with this patch?

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin][RM5455] Cleanup pgAdmin.py
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Rename the README and fix it up to match modern reali