Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not presentwhen seeing generated SQL from a table

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not presentwhen seeing generated SQL from a table
Дата
Msg-id CA+OCxoxsDz04Fn-6P4DPDWZBBu-b5V1tnUJ23AGNj4fXbbBAbA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not presentwhen seeing generated SQL from a table  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Ответы Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not presentwhen seeing generated SQL from a table  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Thanks, applied.

On Thu, Mar 28, 2019 at 2:00 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Just to mention, the patch also fixes RM2627, RM4058.

On Wed, Mar 27, 2019 at 6:25 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch which fixes the issue where comments added in child table on inherited columns where not showing in reverse engineered SQL.

I have also made changes to show column details of inherited columns of table, as well as for "of type" tables similar to pgAdmin3. eg-
CREATE TABLE public.inhactortest
(
-- Inherited from table public.actor: actor_id integer NOT NULL DEFAULT nextval('actor_actor_id_seq'::regclass),
-- Inherited from table public.actor: first_name character varying(45) COLLATE pg_catalog."default" NOT NULL,
-- Inherited from table public.actor: last_name character varying(45) COLLATE pg_catalog."default" NOT NULL,
-- Inherited from table public.test_table: col1 integer,
-- Inherited from table public.test_table: col2 "char",
-- Inherited from table public.test_table: col3 character varying COLLATE pg_catalog."default",
 owncol integer
)
    INHERITS (public.actor, public.test_table)
WITH (
    OIDS = FALSE
)
TABLESPACE pg_default;

ALTER TABLE public.inhactortest
    OWNER to postgres;

COMMENT ON COLUMN public.inhactortest.actor_id
    IS 'in child c';
-- 

Kindly review.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Khushboo Vashi
Дата:
Сообщение: [pgAdmin4][Patch] - RM 4082 - Download CSV error displayed forprocedure and functions with create script
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Add support for IDENTITY columns. Fixes #4030