On Thu, Jan 7, 2016 at 11:56 AM, Björn Harrtell
<bjorn.harrtell@gmail.com> wrote:
> 2016-01-07 12:10 GMT+01:00 Dave Page <dpage@pgadmin.org>:
>>
>> On Thu, Jan 7, 2016 at 7:47 AM, Björn Harrtell <bjorn.harrtell@gmail.com>
>> wrote:
>> > Yes, sorry, I made both the comments and the patch too hastily and agree
>> > that it should not be removed based on my findings.
>> >
>> > It should be noted though that wx3 or GTK3 by themselves is not to blame
>> > here, I'm guessing it should affect wx2 and GTK2 too because it's more
>> > of a
>> > logical problem in where a user created the server node in a light theme
>> > which will save a white color for the background... then if the user
>> > switches to a dark theme, the saved white color is problematic.
>>
>> Well the same applies in a more default theme if you use a dark
>> background. I guess the answer is to say "don't do that then" - I'd
>> certainly prefer not to have pgAdmin try to second guess what colours
>> might work against whatever the theme has for the current text colour.
>
>
> Agreed. But what about saving the color only when making an active choice so
> that the current system window background color is used until the user have
> customized the color?
That seems perfectly reasonable.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company