Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL +0) to reset the zoom level in runtime

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL +0) to reset the zoom level in runtime
Дата
Msg-id CA+OCxowztmd77vXWQzGm19U1ttFomAnm6etWS154=TqH3+FqcA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL +0) to reset the zoom level in runtime  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL +0) to reset the zoom level in runtime  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Nice work! Committed (along with an update to the docs).

Congratulations on your first C++ patch :-)

On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> On Mon, Jun 12, 2017 at 5:27 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch to reset the zoom level in the desktop
>> > runtime.
>> >
>> > Added the new shortcut CTRL + 0 to reset the zoom level.
>>
>> The code looks good, however I don't think resetting to the startup
>> value is really what we want. Shouldn't it reset it to 1.0?
>>
> I have changed the code.
> Also, introduced a single slot for Zoom In/Out/Reset rather than 3
> different.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtimet
Следующее
От: pgAdmin 4 Jenkins
Дата:
Сообщение: [pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #286