Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function

Hi

On Mon, Aug 22, 2016 at 1:42 PM, Priyanka Shendge
<priyanka.shendge@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA patch for schema and database child nodes.  I have divided the patch
> into 2 different patches now.
> Can you please delete "parent_id.pkl" file if exist then apply and run
> schema_and_nodes.patch first as
> db_nodes.patch is dependent on schema_and_nodes.patch.

Thanks - applied.

I noticed whilst testing that I've started seeing the error below
(with or without the patches I just applied). Any idea what's causing
it?

(pgadmin4)piranha:pgadmin4 dpage$ python web/regression/runtests.py
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
This function test the add role scenario (Check Role Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.event_triggers.tests.test_event_trigger_add.EventTriggerAddTestCase)
This function will add event trigger under database node. (Fetch Event
Trigger Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.tests.test_foreign_servers_get.ForeignServerGetTestCase)
This function will fetch foreign server under FDW node. (Check FSRV Node) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (TestCase for Checking
Invalid_Password) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (Empty_Password) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (Empty_Email) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (Empty_Credentials) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (Invalid_Email) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (Invalid_Credentials) ... ok
runTest (pgadmin.browser.tests.test_login.LoginTestCase)
This function checks login functionality. (Valid_Credentials) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.casts.tests.test_cast_put.CastsPutTestCase)
This function will update added cast. (Check Cast Node) ... ok
runTest (pgadmin.browser.tests.test_logout.LogoutTest)
This function checks the logout functionality. (Logging Out) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.extensions.tests.test_extension_add.ExtensionsAddTestCase)
This function will add extension under 1st server of tree node. (Check
Extension Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.tests.test_FDW_add.FDWDAddTestCase)
This function will add extension under 1st server of tree node. (Check
FDW Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.casts.tests.test_cast_add.CastsAddTestCase)
This function will add cast under database node. (Check Cast Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.collations.tests.test_collation_delete.CollationDeleteTestCase)
This function will delete collation under schema node. (Fetch
collation Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_get.SequenceGetTestCase)
This function will fetch added sequence under schema node. (Fetch
sequence Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_delete.TriggerFuncDeleteTestCase)
This function will delete trigger function under database node. (Fetch
Trigger Function Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.event_triggers.tests.test_event_trigger_put.EventTriggerPutTestCase)
This function will update event trigger under database node. (Fetch
Event Trigger Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
This function will fetch the added servers to object browser. (Default
Server Node url) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.event_triggers.tests.test_event_trigger_delete.EventTriggerDeleteTestCase)
This function will delete event trigger under database node. (Fetch
Event Trigger Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
This function tests the update role data scenario (Check Role Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.user_mapping.tests.test_user_mapping_get.UserMappingGetTestCase)
This function will fetch user mapping added to foreign server (Check
user mapping Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.extensions.tests.test_extension_put.ExtensionsPutTestCase)
This function will add extension under 1st server of tree node. (Check
Extension Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_add.TriggerFuncAddTestCase)
This function will add trigger function under schema node. (Fetch
Trigger Function Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
This function test the get table space scenario (Check Tablespace Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.tests.test_foreign_servers_put.ForeignServerPutTestCase)
This function will update foreign server under FDW node. (Check FSRV
Node) ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
This function test the get role scenario (Check Role Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
This function will fetch added database. (Check Dat abases Node URL) ... ok
runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase)
This function will check change password functionality. (TestCase for
Validating Incorrect_New_Password) ... ok
runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase)
This function will check change password functionality. (TestCase for
Validating New_Password_Less_Than_Min_Length) ... ok
runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase)
This function will check change password functionality. (TestCase for
Validating Empty_New_Password) ... ok
runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase)
This function will check change password functionality. (TestCase for
Validating Incorrect_Current_Password) ... ok
runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase)
This function will check change password functionality. (TestCase for
Changing Valid_Password) ... ERROR
runTest (pgadmin.browser.server_groups.servers.databases.extensions.tests.test_extension_get.ExtensionsGetTestCase)
This function will add extension under 1st server of tree node. (Check
Extension Node) ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
This function will add the server under default server group. (Default
Server Node url) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
This function will delete schema under database node. (Check Schema
Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
This function will add sequence(s) under schema node. (Fetch sequence
Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
This function will update trigger function under database node. (Fetch
Trigger Function Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.user_mapping.tests.test_user_mapping_delete.UserMappingDeleteTestCase)
This function delete user mapping under foreign server node. (Check
user mapping Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
This function will add database under 1st server of tree node. (Check
Databases Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.tests.test_FDW_delete.FDWDDeleteTestCase)
This function will delete added FDW. (Check FDW Node) ... ok
runTest (pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
This function tests the delete role scenario (Check Role Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
This function will update the comments field of database. (Check
Databases Node) ... ok
runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
This function checks reset password functionality. (TestCase for
Validating Empty Email) ... ok
runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
This function checks reset password functionality. (TestCase for
Validating Invalid_Email) ... ok
runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
This function checks reset password functionality. (TestCase for
Validating Valid_Email) ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
This function tests the update tablespace data scenario (Check
Tablespace Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_put.SchemaPutTestCase)
This function will delete schema under database node. (Check Schema
Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
This function tests the delete table space scenario (Check Tablespace
Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.user_mapping.tests.test_user_mapping_put.UserMappingPutTestCase)
This function update user mapping under foreign server node. (Check
user mapping Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
This function will add schema under database node. (Check Schema Node
URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.casts.tests.test_cast_delete.CastsDeleteTestCase)
This function will delete added cast(s). (Check Cast Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.collations.tests.test_collation_get.CollationGetTestCase)
This function will fetch collation under schema node. (Fetch collation
Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.collations.tests.test_collation_put.CollationPutTestCase)
This function will update collation under schema node. (Fetch
collation Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.tests.test_foreign_servers_delete.ForeignServerDeleteTestCase)
This function will delete foreign server under FDW node. (Check FSRV
Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
This function will delete schema under database node. (Check Schema
Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.extensions.tests.test_extension_delete.ExtensionsDeleteTestCase)
This function will add extension under 1st server of tree node. (Check
Extension Node) ... ok
runTest (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
This function test the add tablespace scenario (Check Tablespace Node) ... ok
runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
This function will check available server groups. (Check Server Group
Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_put.SequencePutTestCase)
This function will update added sequence under schema node. (Fetch
sequence Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.casts.tests.test_cast_get.CastsGetTestCase)
This function will get added cast. (Check Cast Node) ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase)
This function will update the server's comment field. (Default Server
Node url) ... ok
runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
This function will get all available servers under object browser
(Default Server Node url) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
This function will delete trigger function under database node. (Fetch
Trigger Function Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.tests.test_FDW_put.FDWDPutTestCase)
This function will update added FDW. (Check FDW Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_delete.SequenceDeleteTestCase)
This function will delete added sequence under schema node. (Fetch
sequence Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
This function will delete the database. (Check Databases Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.user_mapping.tests.test_user_mapping_add.UserMappingAddTestCase)
This function will add user mapping under foreign server node. (Check
user mapping Node) ... ok
runTest (pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.tests.test_FDW_get.FDWDGetTestCase)
This function will get added FDW. (Check FDW Node) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.event_triggers.tests.test_event_trigger_get.EventTriggerGetTestCase)
This function will fetch event trigger under database node. (Fetch
Event Trigger Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.schemas.collations.tests.test_collation_add.CollationAddTestCase)
This function will add collation under schema node. (Default Node URL) ... ok
runTest
(pgadmin.browser.server_groups.servers.databases.foreign_data_wrappers.foreign_servers.tests.test_foreign_servers_add.ForeignServerAddTestCase)
This function will add foreign server under database node. (Check FSRV
Node) ... ok

======================================================================
ERROR: runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase)
This function will check change password functionality. (TestCase for
Changing Valid_Password)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_change_password.py",
line 91, in runTest
    user_id = json.loads(response.data.decode('utf-8'))['id']
KeyError: 'id'

----------------------------------------------------------------------
Ran 73 tests in 89.574s

FAILED (errors=1)
Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake