Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing
Дата
Msg-id CA+OCxowrguJS2U8hDSg88VJdirRkdVg4OCMWESypMbeJmXz_DA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing
Список pgadmin-hackers
I doubt the order matters, but feel free to change it if it bugs you :-)

On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave 

I have reviewed the patch and after applying it output in pgAdmin4  

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry)
    RETURNS boolean
    LANGUAGE 'sql'
    COST 100.0
    IMMUTABLE NOT LEAKPROOF 
    PARALLEL SAFE
AS $function$
SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)
$function$;

but as per psql it should be 

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry)

 RETURNS boolean

 LANGUAGE sql

 IMMUTABLE PARALLEL SAFE

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)$function$


is this behaviour correct??



On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for functions missing.

Fix: Incorporated the  PARALLEL SAFE support for the functions and procedures for PostgreSQL 9.6.

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 





--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Navnath Gadakh
Дата:
Сообщение: Re: [pgadmin-hackers] pgAdmin4 regression setup
Следующее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Handle sized time/timestamp columns correctly.Fixes