Re: pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

Hi Ashesh,

I have revert back the changes made in backgrid-sizeable.css and override the table.backgrid css of resizable in overrides.css.

Please find the patch and review.

On Wed, Jun 15, 2016 at 10:42 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

OK, I will fix it.

On Wed, Jun 15, 2016 at 10:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Tue, Jun 14, 2016 at 8:21 PM, Dave Page <dpage@pgadmin.org> wrote:

Fix query tool horizontal scrolling of results. Fixes #1362

The backgrid-sizeable's css property 'overflow: hidden' was overriding backgrid table css property and It was reproducible only in runtime.
Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e881695050b8ba4cf99b365ff2c0f4e02d03ced6
Author: Surinder Kumar <surinder.kumar@enterprisedb.com>

Modified Files
--------------
web/pgadmin/static/css/backgrid/backgrid-sizeable-columns.css | 1 -

This is not correct place to handle the issue.

We should not change third party CSS.

We should handle this issue in override.css.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

 

web/pgadmin/static/js/backform.pgadmin.js                     | 5 +----
2 files changed, 1 insertion(+), 5 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers