Re: pgAdmin4 form control error icon position change

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: pgAdmin4 form control error icon position change
Дата
Msg-id CA+OCxowkHXW0OTX18YmbVZnZcuLMpL4FTrwU2qAt+XcHAS4Eyw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pgAdmin4 form control error icon position change  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Thanks Aditya, patch applied.

On Wed, Mar 21, 2018 at 9:34 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Created - https://redmine.postgresql.org/issues/3226


On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello Aditya,

Could you please create new RM for the issue, so that we can keep track of changes, It will be difficult for us to keep track of email for the details.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Team,

This is regarding the position of error icon of a pgAdmin form control. Below are the screenshots. As we can see, the error icon is overlapping the control buttons like the drop down button, spinner up down buttons, etc.




We propose that we can move the error icon to the front of the label of the form control. Below are screenshots.




Attached is the patch for the above changes. 
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949




--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Move the field error indicators in front of theaffec
Следующее
От: Khushboo Vashi
Дата:
Сообщение: Re: v3.0 release on hold