Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Дата
Msg-id CA+OCxoweMnZkvQ8kRUeHxC+tAQhctzsLpkjJYbLqU6Fu=ySjdA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Hi

This doesn't apply  - can you rebase it please?

Thanks.

On Thu, Nov 24, 2016 at 8:57 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> On Fri, Nov 18, 2016 at 7:45 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch for RM #1801: Properly handle databases
>> > with
>> > datallowconn == false.
>> >
>> > Issue: While connecting the database, allowconn parameter was not in
>> > consideration.  Also, the database properties query call was on the
>> > selected
>> > database which was not correct.
>> >
>> > Fix: Put the check of  allowconn, while connecting the database in JS
>> > file.
>> > Also, the database properties query call set to the maintenance
>> > database.
>>
>> All good, but this is just infrastructure for what's really required;
>> i.e. disabling menu options to do things like backups, run the query
>> tool etc. (anything that needs a connection). Can you resolve that
>> please?
>>
>
> Fixed
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Add search/replace support to the Query Tool, includi
Следующее
От: Dave Page
Дата:
Сообщение: Re: Re: [pgAdmin4][Patch]: Fixes #1986 - Properly handle non-ascii characters while loading & saving file