Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website
Дата
Msg-id CA+OCxowNRf8Mr7Lzhz8mvd4od6wwkeVASUzUJ60k_uqchgVmbg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Список pgadmin-hackers
Thanks, applied.

On Tue, Jul 18, 2017 at 2:45 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Dave,

We changed the name of the file and changed the import, this way it should be able to import it correctly.

Thanks
Sarah & Joao

On Tue, Jul 18, 2017 at 8:20 AM, Dave Page <dpage@pgadmin.org> wrote:


On Tue, Jul 18, 2017 at 1:15 PM, Robert Eckhardt <reckhardt@pivotal.io> wrote:
Looks good. 

Thanks. I just noticed though, that we're trying to link to github.css, and failing. Was that intended to be in the same directory as all the scss?
 

I assumed American spelling, should we use proper English spelling? Our prodigious use of the 'z' (pronounced zee) definitely improves our scrabble scores. 

That's a definite benefit. I tend to try to use en_GB by default, partly because I'm, well, English, and partly because I like to wind up people who think the only English is en_US (of which there are a surprisingly large amount).
 

-- Rob

On Tue, Jul 18, 2017 at 7:54 AM, Dave Page <dpage@pgadmin.org> wrote:


On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers,

With this patch we added the style guide to the current pgAdmin website. It is not 100% migrated yet, but we already have the Alerts and colors.


Thanks - applied with some minor styling and layout changes. Please check I didn't break anything.

You obviously miss-spelt "colour", but I let that slide :-p 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Webpack all the things! Fixes #2135