Re: Build failed in Jenkins: pgadmin4-master-python26 #602

Hi Dave,

On Fri, Feb 9, 2018 at 8:40 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi,

Doesn't this need to include 2.7 in the test that'll install the newer version of psycopg2? e.g.

psycopg2>=2.7.3.2; python_version >= '2.7'

Sorry for the typo.

 

psycopg2==2.7.3.2; python_version < '2.7'

Also, I think the change as written breaks the wheel generation (see the comment at the top of requirements.txt). Changes are required inpkg/pip/setup_pip.py aren't they?

If we use the latest version of pip then we can also use psycopg2 binary package which will save us from compiling the 

psycopg2 

​​

source on client.

http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

I have attached both patches, 

Please review

​ & check which one suites to our need., I've tested both patches and its working fine.

​