Re: Support JSON Editor for JSON type data in pgAdmin

Поиск

Список

Период

Сортировка

От	Dave Page
Тема	Re: Support JSON Editor for JSON type data in pgAdmin
Дата	15 июля 2021 г. 15:48:01
Msg-id	CA+OCxow=ASjdfFHAJ=FD6kJkTxmnfL+9J+SZ04-nkYw4F4SPVw@mail.gmail.com обсуждение исходный текст
Ответы	Re: Support JSON Editor for JSON type data in pgAdmin (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Список	pgadmin-hackers

Дерево обсуждения

On Thu, Jul 15, 2021 at 12:57 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:

Hi Dave/Team,
As part of Feature #5198 current text editor in data-grid is enhanced using this json editor for json type data.
This is licensed under Apache-2.0.

This Jsoneditor provides different modes to view/edit json data. PFA attached SS.

Nice!

Should pgAdmin support all of these modes?

I think so.

Also the editor supports transformation of existing data using ordering & query language.PFA attached SS.
Should pgAdmin also provide data transformation option?

It's there, so yes.

Also while using Code mode, a hyperlink shown - 'powered by ace'.
Can pgAdmin hide this text?

Yes (via CSS overrides - I'd rather not customize or vendorise the component). Having it there is not a requirement of the Apache 2.0 licence; we comply with that and give due credit through other means (consistent with other modules/libraries).

It seems like you've done all the integration work, unless your screenshots are mockups. I think the main thing I can see that clearly needs to be done is styling. We need to make sure that it follows our themes, from colours, to button design, and even syntax highlighting, to ensure it looks like a native part of pgAdmin.