Hi,
On Mon, May 17, 2021 at 3:07 PM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> Hi
>
> After 86dc900, In " src/include/nodes/pathnodes.h ",
> I noticed that it uses the word " partitioned UPDATE " in the comment above struct RowIdentityVarInfo.
>
> But, it seems " inherited UPDATE " is used in the rest of places.
> Is it better to keep them consistent by using " inherited UPDATE " ?
Yeah, I would not be opposed to fixing that. Like this maybe (patch attached)?
- * In partitioned UPDATE/DELETE it's important for child partitions to share
+ * In an inherited UPDATE/DELETE it's important for child tables to share
While at it, I also noticed that the comment refers to the
row_identity_vars, but it can be unclear which variable it is
referring to. So fixed that too.
--
Amit Langote
EDB: http://www.enterprisedb.com