On Fri, May 27, 2022 at 5:11 PM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
> On 24.05.22 23:23, Zhihong Yu wrote:
> > Hi,
> >
> > AT_EnableTrig, /* ENABLE TRIGGER name */
> > + AT_EnableTrigRecurse, /* internal to commands/tablecmds.c */
> > AT_EnableAlwaysTrig, /* ENABLE ALWAYS TRIGGER name */
> > + AT_EnableAlwaysTrigRecurse, /* internal to commands/tablecmds.c */
> >
> > Is it better to put the new enum's at the end of the AlterTableType?
> >
> > This way the numeric values for existing ones don't change.
>
> That's a concern if backpatching. Otherwise, it's better to put them
> like shown in the patch.
Agreed.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com