Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

Поиск
Список
Период
Сортировка
От Evan Jones
Тема Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH
Дата
Msg-id CA+HWA9aGeSzLRuvAh8wksenpnu=q0HjXnNfNH2H8YByz5gps3g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH  (Peter Eisentraut <peter@eisentraut.org>)
Список pgsql-hackers
Дерево обсуждения
On Mon, Jun 5, 2023 at 10:33 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Note that this is a known issue
Yeah.  We have attempted to work around this before, but failed to find
a solution without more downsides than upsides.  I will be interested
to look at this patch, but lack time for it right now.  Anybody else?

Ah, I didn't find that mention in the documentation when I was trying to get this working. Sorry about that!

My argument in favour of considering this patch is that making "./configure; make; make check" work on current major operating systems makes it easier for others to contribute in the future. I think the disadvantage of this patch is it makes pg_regress harder to understand, because it requires an #ifdef for this OS specific behaviour, and obscures the command lines of the child processes it spawns.

Thanks for considering it!

Evan

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Evan Jones
Дата:
Сообщение: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Следующее
От: "Tristan Partin"
Дата:
Сообщение: Potential us of initialized memory in xlogrecovery.c