On 3/17/21 7:59 AM, wenjing wrote: > ok > > The cause of the problem is that the name of the dependent function > (readNextTransactionID) has changed. I fixed it. > > This patch(V43) is base on 9fd2952cf4920d563e9cea51634c5b364d57f71a > > Wenjing > >
I have fixed this patch so that
a) it applies cleanly
b) it uses project best practice for catalog Oid assignment.
However, as noted elsewhere it fails the recovery TAP test.
# run stats by itself because its delay may be insufficient under heavy load test: stats + +# global temp table test +test: gtt_stats +test: gtt_function +test: gtt_prepare +test: gtt_parallel_1 gtt_parallel_2 +test: gtt_clean
Tests that need to run in parallel should use either the isolation tester framework (which is explicitly for testing things concurrently) or the TAP test framework.
Adding six test files to the regression test suite for this one feature is not a good idea. You should have one regression test script ideally, and it should be added as appropriate to both the parallel and serial schedules (and not at the end). Any further tests should be added using the other frameworks mentioned.
Thank you for your advice.
I have simplified the case in regress and put further tests into the Isolation Tester Framework based on your suggestion. And I found a few bugs and fixed them.