On Feb 29, 2012, at 6:02 PM, Bruce Momjian wrote:
> On Wed, Feb 29, 2012 at 04:34:24PM -0500, Robert Haas wrote:
>> On Tue, Feb 28, 2012 at 9:45 PM, Bruce Momjian <bruce@momjian.us> wrote:
>>> OK, I have implemented both Roberts and Àlvaro's ideas in my patch.
>>> I only add the .old suffix to pg_controldata when link mode is used, and
>>> I now do it after the schema has been created (the most common failure
>>> case for pg_upgrade), and just before we actually link files --- both
>>> very good ideas.
>>
>> Thanks for working on this. I think this will be a significant
>> usability improvement.
>
> Glad I got such good feedback and ideas.
>
>> Any ideas about improving the error reporting more generally, so that
>> when reloading the dump fails, the user can easily see what went
>> belly-up, even if they didn't use -l?
>
> The only idea I have is to write the psql log to a temporary file and
> report the last X lines from the file in case of failure. Does that
> help?
>
Perhaps pg_upgrade can print the path to the temp file containing the log and instruct the user to look there for more
detail.
Cheers,
M