Re: [bug fix] pg_ctl always uses the same event source
От | MauMau |
---|---|
Тема | Re: [bug fix] pg_ctl always uses the same event source |
Дата | |
Msg-id | C8293F3BCF00430E978A8C36462CF71A@maumau обсуждение исходный текст |
Ответ на | Re: [bug fix] pg_ctl always uses the same event source (Amit Kapila <amit.kapila16@gmail.com>) |
Ответы |
Re: [bug fix] pg_ctl always uses the same event source
|
Список | pgsql-hackers |
From: "Amit Kapila" <amit.kapila16@gmail.com> Only one minor suggestion: + Name of the event source for pg_ctl to use for event log. The + default is PostgreSQL. >From this description, it is not clear when the event log will be used in pg_ctl. For example, if user uses -e option with register, then he might expect any failure during register command will be logged into eventlog, but that is not true. So I think we should improve the docs to reflect the usage of -e. On Linux, I am getting below build failure for pg_ctl pg_ctl.c: In function ‘main’: pg_ctl.c:2173: error: ‘event_source’ undeclared (first use in this function) pg_ctl.c:2173: error: (Each undeclared identifier is reported only once pg_ctl.c:2173: error: for each function it appears in.) make[3]: *** [pg_ctl.o] Error 1 make[2]: *** [all-pg_ctl-recurse] Error 2 make[1]: *** [all-bin-recurse] Error 2 make: *** [all-src-recurse] Error 2 Thank you for reviewing and testing. I changed the doc, but I'd appreciate it if you could improve my poor English and update the CommitFest if it can be better. I rebased the patch to HEAD and removed the compilation error on Linux. I made event_source variable on all platforms like register_servicename, although they are not necessary on non-Windows platforms. Regards MauMau
Вложения
В списке pgsql-hackers по дате отправления: