Re: old_snapshot: add test for coverage

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: old_snapshot: add test for coverage
Дата
Msg-id C3CB0C0A-3B59-488E-8B8D-8A158990AC9D@yesql.se
обсуждение исходный текст
Ответ на Re: old_snapshot: add test for coverage  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения 
> On 8 Aug 2022, at 07:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Dong Wook Lee <sh95119@gmail.com> writes:

>> I wrote a test of the old_snapshot extension for coverage.
> 
> Hmm, does this really provide any meaningful coverage?  The test
> sure looks like it's not doing much.

Looking at this I agree, this test doesn't provide enough to be of value and
the LIMIT 0 might even hide bugs under a postive test result.  I think we
should mark this entry RwF.

--
Daniel Gustafsson        https://vmware.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Spyridon Dimitrios Agathos
Дата:
Сообщение: CREATE UNLOGGED TABLE seq faults when debug_discard_caches=1
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Introduce a new view for checkpointer related stats