>IMO, we should add details about how this new field is used in the comments on top of XLogRecordBlockImageHeader,
meaningthat when a page hole is present we use the compression info structure and when there is no hole, we are sure
thatthe FPW raw length is BLCKSZ meaning that the two bytes of the CompressionInfo stuff is unnecessary.
This comment is included in the patch attached.
> For correctness with_hole should be set even for uncompressed pages. I think that we should as well use it for sanity
checksin xlogreader.c when decoding records.
This change is made in the attached patch. Following sanity checks have been added in xlogreader.c
if (!(blk->with_hole) && blk->hole_offset != 0 || blk->with_hole && blk->hole_offset <= 0))
if (blk->with_hole && blk->bkp_len >= BLCKSZ)
if (!(blk->with_hole) && blk->bkp_len != BLCKSZ)
Thank you,
Rahila Syed
______________________________________________________________________
Disclaimer: This email and any attachments are sent in strictest confidence
for the sole use of the addressee and may contain legally privileged,
confidential, and proprietary data. If you are not the intended recipient,
please advise the sender by replying promptly to this email and then delete
and destroy this email and any attachments without any further use, copying
or forwarding.