Re: Assignment before assert

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Assignment before assert
Дата
Msg-id C0DAA79C-1405-455E-BD73-0FC6134FEE6D@yesql.se
обсуждение исходный текст
Список pgsql-hackers
> On 13 Feb 2025, at 18:08, Dmitry Koval <d.koval@postgrespro.ru> wrote:
>
> Hi!
> Function EvalPlanQualFetchRowMark contains an assignment
>
> ExecRowMark *erm = earm->rowmark;
>
> before assert
>
> Assert(earm != NULL);
>
> Maybe these lines need to be swapped?

That does admittedly look a bit odd, that assertion can't be reached if earm is
null since we've already dereferenced it by then.  I'll have another look after
coffee but something along the lines of your patch looks right (or just remove
the Assertion perhaps).

--
Daniel Gustafsson




В списке pgsql-hackers по дате отправления: