Re: Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

On 13-01-21 02:28 AM, Andres Freund wrote:
>
> I haven't removed it from the patch afaik, so it would be great to get a
> profile here! Its "only" for xlogdump, but that tool helped me immensely
> and I don't want to maintain it independently...

Here is the output from tprof

Here is the baseline:

Average time 37862

Total Ticks For All Processes (./postgres_perftest) = 19089



Subroutine                 Ticks    %   Source Address  Bytes
==========                 ===== ====== ====== =======  =====
.AllocSetAlloc              2270   0.99 aset.c 3bfb8    4b0
.base_yyparse               1217   0.53 gram.c fe644  168ec
.text                       1015   0.44 copyfuncs.c 11bfb4   4430
.MemoryContextAllocZero      535   0.23 mcxt.c 3b990     f0
.MemoryContextAlloc          533   0.23 mcxt.c 3b780     e0
.check_stack_depth           392   0.17 postgres.c 568ac    100
.core_yylex                  385   0.17 gram.c fb5b4   1c90
.expression_tree_walker      347   0.15 nodeFuncs.c 50da4    750
.AllocSetFree                308   0.13 aset.c 3c998    1b0
.grouping_planner            242   0.11 planner.c 2399f0   1d10
.SearchCatCache              198   0.09 catcache.c 7ec20    550
._SPI_execute_plan           195   0.09 spi.c 2f0c18    7c0
.pfree                       195   0.09 mcxt.c 3b3b0     70
query_dependencies_walker    185   0.08 setrefs.c 255944    1b0
.GetSnapshotData             183   0.08 procarray.c 69efc    460
.query_tree_walker           176   0.08 nodeFuncs.c 50ae4    210
.strncpy                     168   0.07 strncpy.s ba080    130
.fmgr_info_cxt_security      166   0.07 fmgr.c 3f7b0    850
.transformStmt               159   0.07 analyze.c 29091c   12d0
.text                        141   0.06 parse_collate.c 28ddf8      1
.ExecInitExpr                137   0.06 execQual.c 17f18c   15f0
.fix_expr_common             132   0.06 setrefs.c 2557e4    160
.standard_ExecutorStart      127   0.06 execMain.c 1d9a00    940
.GetCachedPlan               125   0.05 plancache.c ce664    310
.strcpy                      121   0.05 noname 3bd40    1a8


With your changes (same test as I described before)

Average: 37938


Total Ticks For All Processes (./postgres_perftest) = 19311

Subroutine                 Ticks    %   Source Address  Bytes
==========                 ===== ====== ====== =======  =====
.AllocSetAlloc              2162   2.17 aset.c 3bfb8    4b0
.base_yyparse               1242   1.25 gram.c fdc7c  167f0
.text                       1028   1.03 copyfuncs.c 11b4d0   4210
.palloc                      553   0.56 mcxt.c 3b4c8     d0
.MemoryContextAllocZero      509   0.51 mcxt.c 3b9e8     f0
.core_yylex                  413   0.41 gram.c fac2c   1c60
.check_stack_depth           404   0.41 postgres.c 56730    100
.expression_tree_walker      320   0.32 nodeFuncs.c 50d28    750
.AllocSetFree                261   0.26 aset.c 3c998    1b0
._SPI_execute_plan           232   0.23 spi.c 2ee624    7c0
.GetSnapshotData             221   0.22 procarray.c 69d54    460
.grouping_planner            211   0.21 planner.c 237b60   1cf0
.MemoryContextAlloc          190   0.19 mcxt.c 3b738     e0
.query_tree_walker           184   0.18 nodeFuncs.c 50a68    210
.SearchCatCache              182   0.18 catcache.c 7ea08    550
.transformStmt               181   0.18 analyze.c 28e774   12d0
query_dependencies_walker    180   0.18 setrefs.c 25397c    1b0
.strncpy                     175   0.18 strncpy.s b9a60    130
.MemoryContextCreate         167   0.17 mcxt.c 3bad8    160
.pfree                       151   0.15 mcxt.c 3b208     70
.strcpy                      150   0.15 noname 3bd40    1a8
.fmgr_info_cxt_security      146   0.15 fmgr.c 3f790    850
.text                        132   0.13 parse_collate.c 28bc50      1
.ExecInitExpr                125   0.13 execQual.c 17de28   15e0
.expression_tree_mutator     124   0.12 nodeFuncs.c 53268   1080
.strcmp                      122   0.12 noname 1e44    158
.fix_expr_common             117   0.12 setrefs.c 25381c    160




> Greetings,
>
> Andres Freund
>