On 11-06-28 02:14 PM, Martin Pihlak wrote: <blockquote cite="mid:4E0A1A14.2070709@gmail.com" type="cite">Thanks for
thereview!<br /><pre wrap="">
I have since simplified the patch to assume that partial SSL writes are
disabled -- according to SSL_write(3) this is the default behaviour.
Now the SSL retry buffer only holds the data to be retried, the
remainder is moved to the new outBuffer.
</pre></blockquote><br /> That sounds okay. Does it make sense to add in a check to verify that SSL didn't send a
partialwrite? I don't know how bad openssl is about changing default behaviours or if we are concerned about
protectingagainst someone changing the SSL parameters. My inclination is that this isn't needed but I'll raise the
issue.<br/> Fixed.<br /><blockquote cite="mid:4E0A1A14.2070709@gmail.com" type="cite"><pre wrap="">
New version of the patch attached.
</pre></blockquote><br /> Otherwise this version of the patch looks good to me.<br /><br /> The only testing I have
doneis running the test program you sent earlier on in the thread and verified that the regression tests all pass.
Otherthan something like your test program I'm not sure how else this bug can be induced.<br /><br /> Since the
originalpatch was submitted as a WIP patch and this version wasn't sent until well into the commit fest I am not sure
ifit qualifies for a committer during this commitfest or if it needs to wait until the next one.<br /><br /><br /><br
/><br/><br /><blockquote cite="mid:4E0A1A14.2070709@gmail.com" type="cite"><pre wrap="">regards,
Martin
</pre> <pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
</pre></blockquote><br />