> On 21 Apr 2023, at 07:29, Gurjeet Singh <gurjeet@singh.im> wrote:
>
> Commit [1] implements Fisher-Yates shuffling algorithm to shuffle
> connection addresses, in two places.
>
> The attached patch moves the duplicated code to a function, and calls
> it in those 2 places.
The reason I left it like this when reviewing and committing is that I think it
makes for more readable code. The amount of lines saved is pretty small, and
"shuffle" isn't an exact term so by reading the code it isn't immediate clear
what such a function would do. By having the shuffle algorithm where it's used
it's clear what the code does and what the outcome is. If others disagree I
can go ahead and refactor of course, but I personally would not deem it a net
win in code quality.
--
Daniel Gustafsson