Re: Remove redundant assignment of a variable in function AlterPublicationTables

On Aug 21, 2025, at 09:10, Peter Smith <smithpb2250@gmail.com> wrote:

I feel that having redundant assignments can be misleading because
someone reading the code might think the initial value matters or has
some significance, when it does not.

~~~

Here's another example, in the same function:
----------
               PublicationRelInfo *newpubrel;
               Oid         newrelid;
               Bitmapset  *newcolumns = NULL;
----------

None of those initial values above is needed because these variables
are all immediately/unconditionally reassigned. So, why is 'newpubrel'
not assigned up-front, but  'newcolumns' is assigned? IMO this implies
that the 'newcolumns' initial value has some meaning (which it
doesn't), so it just introduces unnecessary doubts for the reader...