Re: Show comments in \dRp+, \dRs+, and \dX+ psql meta-commands

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: Show comments in \dRp+, \dRs+, and \dX+ psql meta-commands
Дата
Msg-id BD01E3AE-0B41-4558-8FAD-7927FF6FFB0E@gmail.com
обсуждение исходный текст
Ответ на Re: Show comments in \dRp+, \dRs+, and \dX+ psql meta-commands  (Chao Li <li.evan.chao@gmail.com>)
Список pgsql-hackers

> On Feb 26, 2026, at 13:07, Chao Li <li.evan.chao@gmail.com> wrote:
>
>
>
>> On Feb 26, 2026, at 11:32, Fujii Masao <masao.fujii@gmail.com> wrote:
>>
>>
>>> One unrelated thing caught my attention though: NULLs and empty strings
>>> are both displayed as NULL, which is expected according to
>>> CreateComments() in comment.c
>>>
>>> ...
>>> /* Reduce empty-string to NULL case */
>>> if (comment != NULL && strlen(comment) == 0)
>>> comment = NULL;
>>> ...
>>>
>>> However, I couldn't find anything in the docs that clearly says that
>>> it's going to be the case -- at least not in comment.sgml.
>>>
>>> CREATE SEQUENCE s1;
>>> COMMENT ON SEQUENCE s1 IS '';
>>> CREATE SEQUENCE s2;
>>> COMMENT ON SEQUENCE s2 IS NULL;
>>>
>>> postgres=# \ds+
>>> List of sequences
>>> -[ RECORD 1 ]-----------
>>> Schema      | public
>>> Name        | s1
>>> Type        | sequence
>>> Owner       | jim
>>> Persistence | permanent
>>> Size        | 8192 bytes
>>> Description | (null)
>>> -[ RECORD 2 ]-----------
>>> Schema      | public
>>> Name        | s2
>>> Type        | sequence
>>> Owner       | jim
>>> Persistence | permanent
>>> Size        | 8192 bytes
>>> Description | (null)
>>>
>>> Is it perhaps an undocumented behaviour?
>>
>> I'm not sure why this behavior isn't documented, but it seems worth
>> addressing in a separate documentation patch.
>>
>
> Actually, I am right about to post a doc patch for that. I noticed that while reviewing the other patch about comment
beforethe holiday vacation. My patch will be out today or tomorrow. 
>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>

Hi Fujii-san,

This is the tiny patch to enhance the doc of COMMON ON command. Would you please take a look? Thanks a lot.

https://www.postgresql.org/message-id/26476097-B1C1-4BA8-AA92-0AD0B8EC7190%40gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







В списке pgsql-hackers по дате отправления: