Re: disallow alter individual column if partition key contains wholerow reference

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: disallow alter individual column if partition key contains wholerow reference
Дата
Msg-id BC70B906-F2D3-4833-8F43-2C94FA0D0112@gmail.com
обсуждение исходный текст
Ответ на Re: disallow alter individual column if partition key contains wholerow reference  (jian he <jian.universality@gmail.com>)
Ответы Re: disallow alter individual column if partition key contains wholerow reference
Список pgsql-hackers
Дерево обсуждения
Hi Jian,

On Aug 25, 2025, at 10:22, jian he <jian.universality@gmail.com> wrote:


hi.
minor comments changes,
also add it on commitfest (https://commitfest.postgresql.org/patch/5988)
<v2-0001-fix-wholerow-as-partition-key-reference.patch>

I tested this patch with “partition by range”, it works for me.

Just have a few small comments:

+                       if (bms_is_member(0 - FirstLowInvalidHeapAttributeNumber, expr_attrs))

Can we simply check “if (Var *)expr->varno == 1 && (Var *) expr->varattno == 0”, which seems more direct?

+                       /*
+                        * If partition expression contains wholerow reference, then any
+                        * column is indirect part of the expression now.  unconditionally
+                        * set used_in_expr to true.
+                       */

For the comment, a tiny enhancement:

/*
 * If the partition expression contains a whole-row reference, then every
 * column is implicitly part of the expression. Set used_in_expr to true
 * unconditionally.
 */

Best reagards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




В списке pgsql-hackers по дате отправления: