Hi All,
Great thanks for your kindness and quick reply. Fixing those bugs
will help many people in China who plan to study Pgsql.
Regards,
Jacky
>From: Bruce Momjian <pgman@candle.pha.pa.us>
>To: Tom Lane <tgl@sss.pgh.pa.us>
>CC: Zhong Jacky <jackyzhongxp@msn.com>, pgsql-bugs@postgresql.org
>Subject: Re: [BUGS] pgsql 8.0 beta1 patch for token and timezone
>Date: Thu, 7 Oct 2004 13:29:11 -0400 (EDT)
>
>OK, fixed.
>
>---------------------------------------------------------------------------
>
>Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > + /*
> > > + * Escape any single quotes or backslashes in locale
> > > + */
> > > + static void
> > > + escape_locale(char **locale)
> > > + {
> > > + int len = strlen(*locale),
> > > + i, j;
> > > + char *loc_temp = xmalloc(len * 2);
> > > +
> > > + for (i = 0, j = 0; i < len; i++)
> > > + {
> > > + if ((*locale)[i] == '\'' || (*locale)[i] == '\\')
> > > + loc_temp[j++] = '\\';
> > > + loc_temp[j++] = (*locale)[i];
> > > + }
> > > + *locale = loc_temp;
> > > + }
> >
> > Surely this is quite broken. You need to xmalloc one more byte and
> > add a '\0'.
> >
> > regards, tom lane
> >
> > ---------------------------(end of
broadcast)---------------------------
> > TIP 5: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/docs/faqs/FAQ.html
> >
>
>--
> Bruce Momjian | http://candle.pha.pa.us
> pgman@candle.pha.pa.us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania
19073
_________________________________________________________________
Ãâ·ÑÏÂÔØ MSN Explorer: http://explorer.msn.com/lccn