Re: adding a new column in IDENTIFY_SYSTEM

Поиск
Список
Период
Сортировка
От Jaime Casanova
Тема Re: adding a new column in IDENTIFY_SYSTEM
Дата
Msg-id BANLkTinyBfKXyiHoB4nBd007Nyr6e9qasA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: adding a new column in IDENTIFY_SYSTEM  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: adding a new column in IDENTIFY_SYSTEM
Список pgsql-hackers
On Tue, May 24, 2011 at 8:52 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

> +       primary_xlp_magic = atoi(PQgetvalue(res, 0, 2));
>
> You wrongly get the third field (i.e., current xlog location) as the
> WAL version.
> You should call PQgetvalue(res, 0, 3), instead.
>
>> errdetail("Expected 1 tuple with 3 fields, got %d tuples with %d fields.",
>
> You need to change the above message.
>

Fixed.

About you comments on the check... if you read the thread, you will
find that the whole reason for the field is future improvement, but
everyone wanted some use of the field now... so i made a patch to use
it in pg_basebackup before the transfer starts and avoid time and
bandwith waste but Magnus prefer this in walreceiver...

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte y capacitación de PostgreSQL

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Greg Smith
Дата:
Сообщение: Re: 9.2 schedule
Следующее
От: Josh Kupershmidt
Дата:
Сообщение: Re: patch: Allow \dd to show constraint comments