On Wed, Jun 15, 2011 at 5:10 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> On 14.06.2011 17:57, Kevin Grittner wrote:
>>
>> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com> wrote:
>>
>>> I did some further changes, refactoring SkipSerialization so that
>>> it's hopefully more readable, and added a comment about the
>>> side-effects. See attached. Let me know if I'm missing something.
>>
>> I do think the changes improve readability. I don't see anything
>> missing, but there's something we can drop. Now that you've split
>> the read and write tests, this part can be dropped from the
>> SerializationNeededForWrite function:
>>
>> +
>> + /* Check if we have just become "RO-safe". */
>> + if (SxactIsROSafe(MySerializableXact))
>> + {
>> + ReleasePredicateLocks(false);
>> + return false;
>> + }
>>
>> If it's doing a write, it can't be a read-only transaction....
>
> Ah, good point. Committed with that removed.
Does this mean that the open item "more SSI loose ends" can now be
marked resolved?
http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company