On Mon, Apr 25, 2011 at 11:22 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Robert Haas <robertmhaas@gmail.com> writes:
>>>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
>>>>> I noticed again that make check in contrib doesn't work, so here is a
>>>>> patch to fix it.
>
>>>> I think it might be more useful to have a check target that actually
>>>> succeeds, even if it does nothing useful.
>
>>> That argument seems a bit irrelevant to the proposed patch.
>
>> How so?
>
> The proposed patch is to fix it, not remove it. Surely that's more
> useful than a no-op target.
Oh, that's different... never mind.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company