Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation
От | MauMau |
---|---|
Тема | Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation |
Дата | |
Msg-id | B8A9EC1E51FD45A281A3B61F5744B4A1@maumau обсуждение исходный текст |
Ответ на | Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation (Asif Naeem <anaeem.it@gmail.com>) |
Ответы |
Re: [bug fix] PostgreSQL fails to start on Windows if it
crashes after tablespace creation
Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation |
Список | pgsql-hackers |
From: "Asif Naeem" <anaeem.it@gmail.com> > As you have followed destroy_tablespace_directories() function, Is there any specific reason not to use same logic to detect type of the file/link i.e. “(lstat(linkloc, &st) == 0 && S_ISDIR(st.st_mode))”, It also seems have more appropriate error message i.e. Thanks for reviewing and testing the patch. Yes, at first I did what you mentioned, but modified the patch according to some advice in the mail thread. During redo, create_tablespace_directories() needs to handle the case where the $PGDATA/pg_tblspc/xxx is not a symlink but a directory even on UNIX/Linux. Please see TablespaceCreateDbspace is(). destroy_tablespace_directories() doesn't have to handle such situation. Regards MauMau
В списке pgsql-hackers по дате отправления: