> Done. Once you've removed the socket code, a new release seems in
order.
> Sound OK to you?
OK for me. A new release would be proper.
> It seems to me that the current case is correct - in the Unicode
driver
> we *must* run with client_encoding = 'UNICODE' or it won't work
> properly. That said, I wonder if we shouldn't just remove the if()
> altogether, and unconditionally set the client encoding for the
Unicode
> driver.
>
> Don't forget, this won't affect the ANSI/Multibyte case because it's
> inside a "#ifdef UNICODE_SUPPORT".
>
> What do you think Anoop?
>
As this is already inside "#ifdef UNICODE_SUPPORT", I don't find the
necessity for checking it again.
Regards
Anoop