> On Aug 30, 2021, at 12:06 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I've attached rebased patches.
Thanks for these patches, Sawada-san!
The first patch in your series, v12-0001, seems useful to me even before committing any of the rest. I would like to
integratethe new pg_stat_subscription_errors view it creates into regression tests for other logical replication
featuresunder development.
In particular, it can be hard to write TAP tests that need to wait for subscriptions to catch up or fail. With your
viewcommitted, a new PostgresNode function to wait for catchup or for failure can be added, and then developers of
differentprojects can all use that. I am attaching a version of such a function, plus some tests of your patch (since
itdoes not appear to have any). Would you mind reviewing these and giving comments or including them in your next
patchversion?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company