On 9/16/21, 7:21 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> + GetHugePageSize(&hp_size, &unused);
> + if (hp_size != 0)
> I'd rather change GetHugePageSize() to be able to accept NULL for the
> parameter values, rather than declaring such variables.
Done.
> + To determine the number of huge pages needed, use the
> + <command>postgres</command> command to see the value of
> + <xref linkend="guc-shared-memory-size-in-huge-pages"/>.
> We may want to say as well here that the server should be offline?
> It would not hurt to duplicate this information with
> postgres-ref.sgml.
Done.
> + This setting is supported only on Linux. It is always set to
> Nit: This paragraph is missing two <productname>s for Linux. The docs
> are random about that, but these are new entries.
Done.
Nathan