Re: refactoring comment.c

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: refactoring comment.c
Дата
Msg-id AANLkTintVegwT4v7BofbfpOYcC65n7Q9Ts5nUEaFWUiV@mail.gmail.com
обсуждение исходный текст
Ответ на Re: refactoring comment.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: refactoring comment.c  (Alvaro Herrera <alvherre@commandprompt.com>)
Список pgsql-hackers
On Tue, Aug 17, 2010 at 2:49 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Aug 17, 2010 at 2:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I don't insist that the separation has to be crisp.  I'm merely saying
>>> that putting a large chunk of useful-only-at-execution-time code into
>>> backend/parser is the Wrong Thing.
>
>> OK, but there should be a reason for that.  For example, if there are
>> circumstances when we parse a statement, and then time passes, and
>> then we execute it later, that's a good argument for what you're
>> saying here.
>
> Yeah, and that's exactly what happens with utility statements that (for
> example) get into the plan cache.

OK.  I'll have to look through that code some time.

Here's v3.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!
Следующее
От: "David E. Wheeler"
Дата:
Сообщение: Re: Re: [COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the