fix use of posix_fadvise in xlog.c

Поиск
Список
Период
Сортировка
От Mark Wong
Тема fix use of posix_fadvise in xlog.c
Дата
Msg-id AANLkTin_PXWiqMOMS5-vRFXKUc6047T5QFboQqKsyHn4@mail.gmail.com
обсуждение исходный текст
Ответы Re: fix use of posix_fadvise in xlog.c  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Список pgsql-hackers
Hi all,

I wanted to propose a fix for to xlog.c regarding the use of
posix_fadvise() for 9.1 (unless someone feels it's ok for 9.0).
Currently posix_fadvise() is used right before a log file is closed so
it's effectively not doing anything, when posix_fadvise is to be
called.  This patch moves the posix_fadvise() call into 3 other
locations within XLogFileInit() where a file handle is returned.  The
first case is where an existing open file handle is returned.  The
next case is when a file is to be zeroed out.  The third case is
returning a file handle, which may be the file that was just zeroed
out.

Does this look ok?

Regards,
Mark

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Joshua Tolley
Дата:
Сообщение: Re: [PATCH] Add _PG_init to PL language handler documentation
Следующее
От: Fujii Masao
Дата:
Сообщение: Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby