On Mon, Jan 17, 2011 at 07:46, Magnus Hagander <magnus@hagander.net> wrote:
> On Sun, Jan 16, 2011 at 23:02, Dave Page <dpage@pgadmin.org> wrote:
>> On Sun, Jan 16, 2011 at 9:50 PM, Jeremy Palmer <JPalmer@linz.govt.nz> wrote:
>>> It would be really awesome for DBAs admins to be able to run pgscripts from the command line which have developed
inpgadmin. Even better if the programme is distributed with the standard win32 download.
>>>
>>> Would it be possible to revive it and integrate xtra/pgScript into the pgadmin?
>>
>> Well it's already in the source tree, and already integrated into the
>> pgAdmin GUI. All that is needed is a patch to fix the bitrot. As
>> always, patches are welcome.
>
> Seems the first issue at least comes from patch
> 93834d477cd3fb91deacc0946ef845622fd6678d which removed our md5
> support. But there seems to be other issues as well. If you (=Jeremy)
> want to look at this, that'd be great - if not, I can probably look at
> it, but not right now.
>
> (btw, we really should look at making it not compile pgscript twice -
> once for pgadmin and once for the one in xtra/. But that's something
> for another day :D)
Here's a patch that seems to make it work. The issues were:
* md5 no longer available - but also not needed, removed.
* qtIdent() was not available in commandline mode, but needed. This in
turn required db/keywords.c to be linked in.
Comments/objections on patch?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/