On 9 June 2010 16:05, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Jun 9, 2010 at 11:03 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> On Wed, Jun 9, 2010 at 9:35 AM, Dean Rasheed <dean.a.rasheed@gmail.com>=
wrote:
>>>>> Does anyone care that Alias will sometimes be a string, and sometimes=
a number?
>>
>>> After further review, it appears to me that this change is pretty much
>>> required, because otherwise a string like 0xa won't be quoted. =A0I
>>> might think it's OK for "123" to turn into 123, but I'm not going to
>>> be so happy about "0xa" turning into 10. =A0Please test the attached
>>> patch.
>>
>> I still agree with Dean's original proposal: always quote the values of
>> strings.
>
> I'd still rather rip the format out entirely than do that. =A0Dean's
> proposal was based on the idea that it would be safe to quote only the
> values and not the keys, which is not something I care to bank on.
>
Why? There are only a small number of keys, and we're completely in
control of them. You'd very quickly notice if one of them needed
quoting, which is not the case with values.
Dean