On Tue, Sep 21, 2010 at 17:27, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Breaking it up was quite trivial. Here's what I came up with after
>> building on my box. I'm sure there are some on other platforms showing
>> up, but this should be the majority.
>
>> I just realized it does not include contrib, but's that a mechanical
>> copy of the same thing.
>
>> So if we want to go with this way, i have the scripts/changes ready :)
>
> This works for me, modulo some things:
>
> If we are going to ignore *.so at the top level, we also need to ignore
> *.sl (for HPUX) and *.dll (for Windows). I also wonder why we have
*.sl was missing because I didn't know about it.
*.dll was missing because on msvc we always build out of tree. And I
forgot about mingw not doing that :-)
> entries like this:
>
>> +libecpg.a
>> +libecpg.so.*
>
> rather than global ignore patterns for *.a and *.so.[0-9]
Yeah, that seems better.
> We should probably ignore src/Makefile.custom, since that is still a
> supported way to customize builds (and some of us still use it).
Ok, added.
>> diff --git a/src/timezone/.gitignore b/src/timezone/.gitignore
>> new file mode 100644
>> index 0000000..f844c9f
>> --- /dev/null
>> +++ b/src/timezone/.gitignore
>> @@ -0,0 +1 @@
>> +/zic
>
> Why does this entry have a / when none of the rest do? Shouldn't
> we be consistent about that?
We should. I've removed it.
The difference is that "zic" matches zic in any subdirectory and
"/zic" matches just in the top dir. But we're not having any other
thing called zic further down - it's really only a potential problem
at the top level.
How's this?
Btw, what's the "stamp-h" file? Should that be excluded globally?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/