On Fri, Jul 2, 2010 at 8:35 AM, KaiGai Kohei <kaigai@ak.jp.nec.com> wrote:
> (2010/07/01 11:30), Peter Eisentraut wrote:
> I have a question.
>
> The pqGetpwuid() is enclosed by #ifndef WIN32 ... #endif, although
> this patch encloses the section to obtain user id of the peer by
> #ifdef HAVE_UNIX_SOCKETS ... #endif.
>
> Is there any possibilities that both WIN32 and HAVE_UNIX_SOCKETS are
> set concurrently? If possible, the libpq may try to call undefined
> function, then build will be failed.
Win32 never has HAVE_UNIX_SOCKET.
Cygwin might though, I recall some old discussion about that - can't
remember the outcome though, and I can't find it right now.
> I'd like someone to try to build with this patch on win32 platform,
> and report it.
I think cygwin may be the more important one here.
-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/